Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Increase the UART flush delay #12262

Merged
merged 4 commits into from
Jan 16, 2020

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Jan 15, 2020

Summary of changes

  • Increase the value of SERIAL_FLUSH_TIME_MS used to wait for the end of the greentea communication in a couple of tests. The original calculation was based on the 16-byte UART Tx FIFO assumption. This is wrong for CY8CPROTO_062_4343W which uses 128-byte FIFO.
  • Insert UART-flush wait before watchdog reset.

This patch is based on the findings from #11909 (comment).

Fixes #11909

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond, @dustin-crossman


@ciarmcom ciarmcom requested review from jamesbeyond and a team January 15, 2020 14:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-core @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the fixing!

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2020

Ci started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: review labels Jan 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2020

Also the SERIAL_FLUSH_TIME_MS comment mentions that there is currently no mbed API to check if hardware buffers are empty. Do you know if there is any progress on that front? It seems like it would help a lot to prevent similar bugs on other hardware/tests.

From the issue referenced, 👍 having this, to avoid doing this in tests/apps.

@0xc0170 0xc0170 merged commit dd54804 into ARMmbed:master Jan 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2020

My above comment: @fkjagodzinski Do you know where is this being tracked ?

@fkjagodzinski fkjagodzinski deleted the test_update-uart_flush_delay branch January 16, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CY8CPROTO_062_4343W target failed on greentea watchdog test
5 participants