SFDP: Move Sector Map Parameter Table parsing under SFDP module #12318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think testing only 1 QSPI memory is not enough... |
@kyle-cypress The failures seen here with CY8CPROTO_062_4343W are reproducible with Mbed OS master - commit |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
I have a bug somewhere in here. I'll let you you know once I find it and fix it. |
I have been unable to reproduce the issue and I'm pretty certain that the issue I saw with SPIF might have been a glitch which isn't related to my changes. I had following test suite running over night without any issues - 27 iterations this far: |
michalpasztamobica
approved these changes
Feb 7, 2020
added 12 commits
February 7, 2020 09:52
This far all SFDP Sector Map Table related data has been found in small pieces inside QSPIFBlockDevice. Purpose was to consolidate the data under one SFDP structure where all the information gathered from SFDP tables is stored. Parsing a Sector Map Table was made more generic so that later it can be moved under SFDP module. Once that is done it can be shared with SPIFBlockDevice to avoid code duplication.
This far all SFDP Sector Map Table related data has been found in small pieces inside SPIFBlockDevice. Purpose was to consolidate the data under one SFDP structure where all the information gathered from SFDP tables is stored. More generic version of a function used for parsing a Sector Map Table was taken into use to avoid duplicate code. The implementation taken into use is the one which got split from QSPIFBlockDevice and resides now under the SFDP module.
|
Rebased, should be easier to review. |
VeijoPesonen
changed the title
SeppoTakalo
approved these changes
Feb 10, 2020
|
CI started |
kyle-cypress
approved these changes
Feb 10, 2020
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
The device LPC55S69 doesn't have a SPIF- or QSPIF-module so I can't see how my changes would cause any issues with it - logs. @0xc0170 Would you please rerun the tests. |
|
@0xc0170 Would you please restart the tests. |
|
CI rerun (it might fail, we are investigating internal compiler error) |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
Master should be fixed, lets see |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Depends on PR #12270. That one should go in before you start reviewing this one.Purpose of this PR is to consolidate SFDP Sector Map Parameter Table parsing and make the QSPIF- and SPIFBlockDevices to use the same shared implementation. Before this PR almost the same code was found from both of the components.Impact of changes
Migration actions required
Documentation
Pull request type
Test results
SPIF compilation
QSPIF compilation
Reviewers
@SeppoTakalo
@michalpasztamobica