Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXRT1050: Add bootloader support #12359

Merged
merged 1 commit into from
Feb 6, 2020
Merged

MXRT1050: Add bootloader support #12359

merged 1 commit into from
Feb 6, 2020

Conversation

mmahadevan108
Copy link
Contributor

Summary of changes

Add bootloader support for MXRT1050

Impact of changes

NONE

Migration actions required

NONE

Documentation

NONE

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@maclobdell

@ciarmcom ciarmcom requested review from maclobdell and a team February 3, 2020 22:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Feb 4, 2020
View reviewed changes
targets/targets.json Outdated
@@ -14188,7 +14189,7 @@
"smclk_select": "HFXT",
"smclk_div": "DIV2",
"adc_auto_scan": 1
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future reference (as this commit is changing just one line there) but we should remove spaces in own separate commit .

0xc0170
0xc0170 previously approved these changes Feb 4, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Feb 4, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I restarted tests to confirm, but they seem to be either on master or CI is doing something, will investigate further once finished.

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@mergify
Copy link

mergify bot commented Feb 4, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mmahadevan108
MXRT1050: Add bootloader support
013b651 
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mergify mergify bot dismissed 0xc0170’s stale review February 4, 2020 16:40

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

Rebased to fix conflicts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Feb 6, 2020
@0xc0170 0xc0170 merged commit 9e0642d into ARMmbed:master Feb 6, 2020
@mergify mergify bot removed the ready for merge label Feb 6, 2020
@mmahadevan108 mmahadevan108 deleted the MXRT1050_Bootloader_Support branch February 11, 2020 15:54
@adbridge
Copy link
Contributor

Requested by Tuomo for consideration for LTS branch.

@adbridge adbridge added Release review required release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Feb 19, 2020
@artokin artokin mentioned this pull request Mar 3, 2020
Merged
@adbridge
Copy link
Contributor

adbridge commented Apr 8, 2020

This went to a feature branch so assuming this will not go to 5.15 proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmahadevan108 @ciarmcom @0xc0170 @mbed-ci @adbridge