-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated CAN APIs. #12420
Conversation
Can each of this functionality be in a separate commit ? |
We have decided to keep in one PR until if those deprecated APIs has a dependency. |
I don't see the dependencies here between them, however my point was to split commits at least, not PR itself. |
@rajkan01 What do you think about this one - I failed to see the dependencies so could be in this PR just separate commits. Let's progress with this removal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it's a major breaking change.
Please split it into one PR per area, all of them should be major breaking and have the summary/impact/migration sections filled in. |
8e72d7a
to
692f0a2
Compare
38da8a8
to
692f0a2
Compare
@rajkan01 Already not in the docs? (no docs PR needed) ? |
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
@rajkan01 Please confirm that a doc PR is not needed (i.e. documentation changes will be automatically made by doxygen engine) ? |
client test restarted |
This PR does not contain release version label after merging. |
Summary of changes
Removed CAN deprecated APIs.
Impact of changes
With these changes, CAN
attach
APIs with cv-qualifiers sources are removed and this is the breaking changes for the userMigration actions required
Use
attach(callback(obj, method), type)
Documentation
Pull request type
Test results
Reviewers
@evedon