Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated CAN APIs. #12420

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Feb 12, 2020

Summary of changes

Removed CAN deprecated APIs.

Impact of changes

With these changes, CAN attach APIs with cv-qualifiers sources are removed and this is the breaking changes for the user

Migration actions required

Use attach(callback(obj, method), type)

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


evedon
evedon previously approved these changes Feb 12, 2020
@mergify mergify bot added the needs: work label Feb 12, 2020
@mergify mergify bot dismissed evedon’s stale review February 12, 2020 16:39

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2020

Can each of this functionality be in a separate commit ?

@rajkan01
Copy link
Contributor Author

Can each of this functionality be in a separate commit ?

We have decided to keep in one PR until if those deprecated APIs has a dependency.

@ciarmcom ciarmcom requested review from evedon and a team February 12, 2020 18:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-core please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2020

I don't see the dependencies here between them, however my point was to split commits at least, not PR itself.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 17, 2020

I don't see the dependencies here between them, however my point was to split commits at least, not PR itself.

@rajkan01 What do you think about this one - I failed to see the dependencies so could be in this PR just separate commits.

Let's progress with this removal

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's a major breaking change.

@bulislaw
Copy link
Member

Please split it into one PR per area, all of them should be major breaking and have the summary/impact/migration sections filled in.

@rajkan01 rajkan01 force-pushed the drivers_remove_deprecate branch from 8e72d7a to 692f0a2 Compare February 24, 2020 13:04
@rajkan01 rajkan01 force-pushed the drivers_remove_deprecate branch from 38da8a8 to 692f0a2 Compare February 24, 2020 13:13
@rajkan01 rajkan01 changed the title Remove the deprecated Ethernet, Interrupt Manager and CAN APIs. Remove the deprecated CAN APIs. Feb 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

@rajkan01 Already not in the docs? (no docs PR needed) ?

@mergify mergify bot added needs: CI and removed needs: review labels Feb 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mergify mergify bot added the needs: work label Feb 25, 2020
@mergify mergify bot removed the needs: CI label Feb 25, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@evedon
Copy link
Contributor

evedon commented Feb 25, 2020

@rajkan01 Please confirm that a doc PR is not needed (i.e. documentation changes will be automatically made by doxygen engine) ?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

client test restarted

@rajkan01
Copy link
Contributor Author

rajkan01 commented Feb 26, 2020

@rajkan01 Please confirm that a doc PR is not needed (i.e. documentation changes will be automatically made by doxygen engine) ?
@evedon It seems to be no documentation changes required in Mbed-os-5-docs, and Doxygen source code documentation has taken care by Doxygen engine docs generator.

@0xc0170 0xc0170 removed the needs: CI label Feb 26, 2020
@0xc0170 0xc0170 merged commit c966c42 into ARMmbed:master Feb 26, 2020
@mergify
Copy link

mergify bot commented Feb 26, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 26, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants