-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor optimisation to mcr20a-rf-driver code #12427
Conversation
This is a minor optimisation to the mcr20a-rf-driver code: 1. The function parameter is 'uint8_t *byteArray', (byteArray == NULL) instead of using (byteArray == 0). The code is more readable.
@artokin Isn't this code coming from upstream repo, therefore should be fixed there first? |
@0xc0170 we can backport these changes there to keep repositories in sync. |
CI started |
@DavidLin1577 please include a header file for NULL declaration, see Travis errors
|
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
This is a minor optimisation to the mcr20a-rf-driver code: Note that function parameter is pointer. The code is more readable when 'NULL' instead of using '0'.
Pull request has been modified.
@0xc0170 thank you so much. I had changed it as your suggestion. |
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Summary of changes
This is a minor optimisation to the mcr20a-rf-driver code:
Note that function parameter is pointer. The code is more readable when 'NULL' instead of using '0'.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers