Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reset_reason api for cypress targets #12440

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Implement reset_reason api for cypress targets #12440

merged 1 commit into from
Feb 25, 2020

Conversation

dustin-crossman
Copy link
Contributor

Summary of changes

This implements the reset_reason api for cypress targets.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

CY8CPROTO_062_4343W-GCC_ARM.txt
CY8CPROTO_064_SB-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt
CY8CKIT_062_BLE-GCC_ARM.txt

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from maclobdell and a team February 14, 2020 20:00
@ciarmcom
Copy link
Member

@dustin-crossman, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot dismissed 0xc0170’s stale review February 18, 2020 18:27

Pull request has been modified.

0xc0170
0xc0170 reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minimal change and lets get this in CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 98db255 into ARMmbed:master Feb 25, 2020
@mergify mergify bot removed the ready for merge label Feb 25, 2020
@0xc0170 0xc0170 mentioned this pull request Feb 27, 2020
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

This PR potentionaly broke the build for FUTURE_SEQUANA targets, see #12523

@dustin-crossman
Copy link
Contributor Author

Woops! Fixed up here: #12530

@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@Mergifyio backport mbed-os-5.15

@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@dustin-crossman as Ian has requested this be backported to 5.15, do I also assume that #12530 should also be backported? That was not on his spreadsheet ?

@dustin-crossman
Copy link
Contributor Author

@adbridge Yea #12530 should also be backported. He must have just missed it.

@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
Backport Candidate devices: cypress release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dustin-crossman @ciarmcom @0xc0170 @mbed-ci @adbridge