Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBED_STACK_STATS_ENABLED : Add stack_name information in greentea metrics #12466

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Proposition is to add the thread name in the metrics that GreenTea displays at the end of each test.

Impact of changes

Example of result:

[1582104789.02][CONN][INF] found KV pair in stream: {{__thread_info;"main","0x020005db0",544,4096}}, queued...
[1582104789.08][CONN][INF] found KV pair in stream: {{__thread_info;"rtx_idle","0x020005df4",64,896}}, queued...
[1582104789.12][CONN][INF] found KV pair in stream: {{__thread_info;"rtx_timer","0x020005e38",96,768}}, queued...

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team February 19, 2020 10:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team February 21, 2020 14:11
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Feb 24, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Feb 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

test restarted (all passed)

@0xc0170 0xc0170 merged commit 9ad292a into ARMmbed:master Feb 28, 2020
@mergify mergify bot removed the ready for merge label Feb 28, 2020
@jeromecoutant jeromecoutant deleted the PR_METRIC branch March 2, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants