Inline nsapi_create_stack(NetworkStack) #12467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the info why we are changing it (the description to the commit msg) ? |
kjbracey
changed the title
|
Added missing description to commit message. |
|
@kjbracey-arm, thank you for your changes. |
0xc0170
previously approved these changes
Feb 21, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
The rather fiddly `nsapi_create_stack` template + overloads used during socket formation don't inline their core, which is the identity operation for `NetworkStack *` itself. Make code generation easier by having that core be inline.
|
Unit test fix |
mergify
bot
dismissed
0xc0170’s stale review
Pull request has been modified.
|
CI restarted |
0xc0170
approved these changes
Feb 21, 2020
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
release-version: 6.0.0-alpha-3
needs: review
and removed
ready for merge
labels
|
@ARMmbed/mbed-os-ipcore Please review |
bulislaw
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The rather fiddly
nsapi_create_stacktemplate + overloads used during socket formation don't inline their core, which is the identity operation forNetworkStack *itself. Make code generation easier by having that core be inline.Impact of changes
Slight code size reduction.
Migration actions required
None.
Documentation
n/a
Pull request type
Test results
Reviewers