Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure when target's cmsis doesn't exist #12476

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Feb 20, 2020

Summary of changes

For bootloader enabled target, it needs to have cmsis pack or provide memory override to build successfully. This PR tries to fix build failure on targets having no cmsis pack but providing memory override with start being zero. Start address of zero is valid but it is misjudged as no memory override.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

For bootloader enabled target, it needs to have cmsis pack or provide memory override. This change fixes build failure in case of no cmsis pack but providing memory override with start being zero.
@ciarmcom ciarmcom requested review from a team February 20, 2020 10:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

I restarted CI, did not propagate results

@mergify mergify bot added needs: work and removed needs: CI labels Feb 26, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2020

Test run: FAILED

Summary: 4 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

Client restarted, the rest looks fine

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

@ARMmbed/mbed-os-tools Please review, if approved, this can go in

@0xc0170 0xc0170 merged commit 37aafc9 into ARMmbed:master Mar 3, 2020
@ccli8 ccli8 deleted the nuvoton_build_no_cmsis branch March 4, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants