Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPDX identifiers and licenses (excluding features and targets) #12480

Merged
merged 17 commits into from
Feb 21, 2020
Merged

Fix SPDX identifiers and licenses (excluding features and targets) #12480

merged 17 commits into from
Feb 21, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 20, 2020

Summary of changes

This is needed for #12437. It includes it here to initially check that licenses are properly fixed (changed files are being checked in travis).

It is lot of files but split to commits per module. It should be quick to review and most of the changes are one liners (SPDX identifier added).

Do not review commit 0531e63 - will be removed as it's part of another PR.

There are 2 cmsis files (will send fix upstream), also some cbor did not contain SPDX. Otherwise most of the files are ours. Components should be checked and send upstream as well.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 20, 2020

I can send each separately but I considered these are easy-to-follow fixes so all in one PR. I excluded features/targets,will send separately via new PRs

@mergify mergify bot added the needs: work label Feb 20, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 20, 2020

License check passed 🎉

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 20, 2020

@Patater @SeppoTakalo @AnttiKauppila Please review (components were touched - wifi/storage/psa), the rest is common code - @evedon

@0xc0170 0xc0170 requested a review from evedon February 20, 2020 15:23
SeppoTakalo
SeppoTakalo previously approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

AnttiKauppila
AnttiKauppila previously approved these changes Feb 20, 2020
View reviewed changes
@0xc0170 0xc0170 mentioned this pull request Feb 20, 2020
Merged
@mergify mergify bot added needs: CI and removed needs: review labels Feb 20, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 20, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 20, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

Patater
Patater reviewed Feb 20, 2020
View reviewed changes
components/TARGET_PSA/TESTS/compliance_attestation/test_a001/main.c
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These attestation tests are from https://github.com/ARM-software/psa-arch-tests and the headers will need to be added there as well, to prevent us from losing the headers when we re-import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will create an issue today with the scan findings there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked psa-arch-tests with scancode, no offenders found - all good there. These tests are only here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they've already added SPDX since our last import. There will be no issue with losing the identifiers. https://github.com/ARM-software/psa-arch-tests/blob/master/api-tests/dev_apis/initial_attestation/test_a001/test_a001.c#L3

@mergify mergify bot dismissed stale reviews from SeppoTakalo and AnttiKauppila February 21, 2020 07:03

Pull request has been modified.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 21, 2020 •
edited
Loading

I removed travis script from this PR (tested, all according our license guide). I'll restart tests now and this is ready for merge.

1 outstanding thing to do outside of this PR will be reporting missing licenses to 3 repos mentioned in this PR. I'll do it shortly

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 21, 2020

Nothing oustanding, CMSIS_5 2 files PR created, trusted firmware issue created. This should be fine to go in as it is now.

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 21, 2020

@adbridge Please review and if all fine, should be ready to merge

adbridge
adbridge approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge adbridge merged commit 8c17270 into ARMmbed:master Feb 21, 2020
@0xc0170 0xc0170 deleted the fix_spdx branch February 24, 2020 07:28
@VeijoPesonen VeijoPesonen mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@adbridge adbridge adbridge approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo left review comments

@AnttiKauppila AnttiKauppila AnttiKauppila left review comments

@evedon evedon Awaiting requested review from evedon

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @mbed-ci @Patater @SeppoTakalo @adbridge @AnttiKauppila