Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++11-ify virtualisation in netsocket #12487

Merged
merged 2 commits into from
Mar 3, 2020
Merged

C++11-ify virtualisation in netsocket #12487

merged 2 commits into from
Mar 3, 2020

Conversation

kjbracey
Copy link
Contributor

Summary of changes

Use override and final where appropriate, and eliminate unnecessary
virtual.

Fixes some mismatches in string-based API removal (#11942)

Some other C++11 simplifications.

Reduces code size.

Marking as breaking change because it fixes up some work in a previous breaking change.

Impact of changes

No new implications.

Migration actions required

No new actions.

Documentation

None.

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@michalpasztamobica

@ciarmcom ciarmcom requested review from michalpasztamobica and a team February 21, 2020 14:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

bulislaw
bulislaw previously approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Feb 24, 2020
0xc0170
0xc0170 previously approved these changes Feb 25, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@kjbracey
Copy link
Contributor Author

Fixed unit tests

@mergify mergify bot dismissed stale reviews from bulislaw and 0xc0170 February 25, 2020 15:16

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest
  • jenkins-ci/mbed-os-ci_exporter

@kjbracey
Copy link
Contributor Author

Spurious test system failures?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

yes, looks like that. Restarted both

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2020

Fixes some mismatches in string-based API removal (#11942)

Why is this part of the commit as well? It's not that easy to find what we have missed. Shouldn't this be separate commit or even PR? The rest looks fine to me.

@kjbracey
Correct NetworkStackWrapper::get_ip_address
695e872 
Previous change that removed string-based APIs missed
`NetworkStackWrapper::get_ip_address`. Remove string-based method (which
is not overriding anything in `NetworkStack`) and add missing binary
form to implement `NetworkStack::get_ip_address`.
@kjbracey
C++11-ify virtualisation in netsocket
d8d35ed 
Use `override` and `final` where appropriate, and eliminate unnecessary
`virtual`.

Some other C++11 simplifications.

Reduces code size.
@kjbracey
Copy link
Contributor Author

Shouldn't this be separate commit or even PR? The rest looks fine to me.

I've split the commits. No end result change.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 2, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

Most likely both failures are known. I have a fix for tests (thread timeout), and client - not yet how to proceed there

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

Ci restarted (tests should be fixed)

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit f4df4e7 into ARMmbed:master Mar 3, 2020
@mergify mergify bot removed the ready for merge label Mar 3, 2020
@kjbracey kjbracey deleted the override_nsapi branch March 4, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@bulislaw bulislaw bulislaw left review comments

Assignees
No one assigned
Labels
mergify skip release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjbracey @ciarmcom @0xc0170 @mbed-ci @bulislaw @michalpasztamobica