C++11-ify virtualisation in lwIP classes #12489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjbracey-arm, thank you for your changes. |
0xc0170
reviewed
Feb 24, 2020
| #if LWIP_IPV6 && LWIP_IPV4 | ||
| return NULL; | ||
| #endif | ||
| return get_ip_address_if(address, nullptr); |
There was a problem hiding this comment.
can we do this in separate commit at least?
There was a problem hiding this comment.
You're right - I'll pull that fixup change to the front.
AnttiKauppila
previously approved these changes
Feb 25, 2020
Previous change that removed string-based APIs missed `LWIP::get_ip_address`. Remove string-based method (which is not overriding anything in `NetworkInterface`) and add missing binary form to implement `NetworkInterface::get_ip_address`.
Use `override` and `final` where appropriate, and eliminate unnecessary `virtual`. Some other C++11 simplifications.
kjbracey
force-pushed
the
override_lwip
branch
from
72af001 to
aa9058a
Compare
mergify
bot
dismissed
AnttiKauppila’s stale review
Pull request has been modified.
0xc0170
approved these changes
Feb 28, 2020
|
CI started |
Test run: FAILEDSummary: 2 of 7 test jobs failed Failed test jobs:
|
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
0xc0170
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
overrideandfinalwhere appropriate, and eliminate unnecessaryvirtual.Fix up
get_ip_addressfollowing string-based API removal (#11942).Some other C++11 simplifications.
Marking as breaking change as it fixes up a previous breaking change.
Impact of changes
No new impact.
Migration actions required
No new migrations
Documentation
None
Pull request type
Test results
Reviewers
@michalpasztamobica