Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++11-ify virtualisation in FileHandle + Serials #12495

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

kjbracey
Copy link
Contributor

Summary of changes

Use override and final where appropriate, and eliminate unnecessary virtual.

Impact of changes

api_lock in BufferedSerial is no longer virtual, unlike UARTSerial. This shouldn't affect applications, as there's no known use for overriding this, unlike the lock methods in basic drivers.

Slight code size reduction.

Migration actions required

None.

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba


@mergify mergify bot added the needs: work label Feb 24, 2020
Use `override` and `final` where appropriate, and eliminate unnecessary
`virtual`.
@ciarmcom ciarmcom requested review from hugueskamba and a team February 24, 2020 10:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@hugueskamba @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 32f615e into ARMmbed:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants