C++11-ify virtualisation in FileHandle + Serials #12495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
override
andfinal
where appropriate, and eliminate unnecessaryvirtual
.Impact of changes
api_lock
inBufferedSerial
is no longer virtual, unlikeUARTSerial
. This shouldn't affect applications, as there's no known use for overriding this, unlike thelock
methods in basic drivers.Slight code size reduction.
Migration actions required
None.
Documentation
None
Pull request type
Test results
Reviewers
@hugueskamba