-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated ethernet APIs #12500
Conversation
…p files and its dependency.
Ethernet
APIs Ethernet
APIs
Ethernet
APIs
The corresponding HAL header ethernet_api.h should also go. |
Can you add this one as well? |
@0xc0170 We will do once started working on HAL folder. |
Could we also link to our handbook: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnotherButler Note that the Eternet API needs to be removed from the docs.
CI started |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
Client restarted |
Does EthInterface documentation still stay? https://os.mbed.com/docs/mbed-os/v5.15/apis/ethernet.html |
Yes, that documents the current API. I don't think the one being removed here is in the docs. It's never been used in Mbed OS 5, it's a 2/classic remnant. |
Summary of changes
The
Ethernet
is no longer supported, so removed header and cpp files and its dependency.Impact of changes
Breaking change: The Ethernet object is removed as it has been deprecated in the previous feature releases.
Migration actions required
Use NetworkInterface instead, for more details have a look at our documentation here
Documentation
Pull request type
Test results
Reviewers
@evedon @bulislaw