-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated the InterruptManager APIs #12501
Conversation
This is the only in-tree user of the deprecated |
That's the plan. We started with |
@rajkan01 This is breaking change, please fix the type and state it also in the description, should be emphasized for reviewers to realize this is breaking (I added a label as well). |
@0xc0170 Yes I have updated the description and the type, please review |
This description is not useful to anyone. Feel free to adapt the wording. The code change looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in comment above.
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnotherButler Note that the InterruptManager API needs to be removed from the docs.
Who will send PR removing this from docs? |
I'll merge this one, docs come later today |
Summary of changes
Removed InterruptManager class as it was deprecated since Mbed 5.6.
Impact of changes
All users of InterruptManager class will need to modify their application.
Migration actions required
The interrupt handlers need to be attached directly using specific drivers, for example, Application handler can use one of the Ticker/Timer/Timeout classes for clock-related interrupts.
Documentation
None
Pull request type
Test results
Reviewers
@evedon @bulislaw