Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated the InterruptManager APIs #12501

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Feb 24, 2020

Summary of changes

Removed InterruptManager class as it was deprecated since Mbed 5.6.

Impact of changes

All users of InterruptManager class will need to modify their application.

Migration actions required

The interrupt handlers need to be attached directly using specific drivers, for example, Application handler can use one of the Ticker/Timer/Timeout classes for clock-related interrupts.

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @bulislaw


@ciarmcom ciarmcom requested review from bulislaw, evedon and a team February 24, 2020 14:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@bulislaw @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@kjbracey
Copy link
Contributor

This is the only in-tree user of the deprecated CallChain, so that could also be removed (follow-up PR?).

@evedon
Copy link
Contributor

evedon commented Feb 24, 2020

This is the only in-tree user of the deprecated CallChain, so that could also be removed (follow-up PR?).

That's the plan. We started with drivers and will move to platform next.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)

@rajkan01 This is breaking change, please fix the type and state it also in the description, should be emphasized for reviewers to realize this is breaking (I added a label as well).

@rajkan01
Copy link
Contributor Author

rajkan01 commented Feb 24, 2020

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)

@rajkan01 This is breaking change, please fix the type and state it also in the description, should be emphasized for reviewers to realize this is breaking (I added a label as well).

@0xc0170 Yes I have updated the description and the type, please review

@mergify mergify bot added needs: CI and removed needs: review labels Feb 24, 2020
@bulislaw
Copy link
Member

Summary of changes
The InterruptManager class is not part of the Mbed OS public API and its no longer supported, so removed header and cpp file.
Impact of changes
With these changes, the InterruptManager APIs sources are removed completely and this is the breaking changes for the users.

Migration actions required
None.

Documentation
None

This description is not useful to anyone.
Summary of changes -> Remove InterruptManager class as it was deprecated since Mbed 5.6.
Impact of changes -> All users of InterruptManager class will need to modify their application.
Migration actions required -> The interrupt handlers need to be attached directly using specific drivers, eg one of the Ticker/Timer/Timout classes for clock related interrupts.

Feel free to adapt the wording. The code change looks good.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in comment above.

@mergify mergify bot added needs: work and removed needs: CI labels Feb 24, 2020
@mergify mergify bot added needs: CI and removed needs: work labels Feb 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnotherButler Note that the InterruptManager API needs to be removed from the docs.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

@AnotherButler Note that the InterruptManager API needs to be removed from the docs.

Who will send PR removing this from docs?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

I'll merge this one, docs come later today

@0xc0170 0xc0170 merged commit 5969fdf into ARMmbed:master Feb 26, 2020
@mergify mergify bot removed the ready for merge label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants