Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: ignore grep return value for scancode #12505

Merged
merged 1 commit into from
Feb 25, 2020
Merged

travis: ignore grep return value for scancode #12505

merged 1 commit into from
Feb 25, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 25, 2020

Summary of changes

The file is not always present in changed files, thus we need to just ignore the
return status.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170
travis: ignore grep return value for scancode
9266ed1 
The file is not always present in changed files, thus we need to just ignore the
return status.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 25, 2020

This should fix the error on master in Travis

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 25, 2020

CI started

@ciarmcom ciarmcom requested a review from a team February 25, 2020 08:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 25, 2020

CI passed, will merge this not causing red flags in new PRs

@0xc0170 0xc0170 merged commit 745a4b4 into ARMmbed:master Feb 25, 2020
@mergify
Copy link

mergify bot commented Feb 25, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 25, 2020
@0xc0170 0xc0170 added release-version: 6.0.0-alpha-3 and removed needs: CI release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Feb 25, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 25, 2020

master green again 💯

@0xc0170 0xc0170 deleted the fix_travis_grep branch February 25, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xc0170 @ciarmcom