Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: release _semaphore only once #12507

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Cellular: release _semaphore only once #12507

merged 1 commit into from
Mar 9, 2020

Conversation

variablo87
Copy link

Summary of changes

Fixes #12325
The semaphore is used only at _is_blocking Mode. So it should released only at _is_blocking Mode.

Documentation

see issue #12325

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

@mergify mergify bot added the needs: work label Feb 25, 2020
@ciarmcom ciarmcom requested review from a team February 25, 2020 10:00
@ciarmcom
Copy link
Member

@variablo87, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

@variablo87 Please review astyle failures (diff there shows the offending lines).

@variablo87 variablo87 force-pushed the cellular-context-semaphore-release branch from 276b8f2 to 327445a Compare February 28, 2020 14:09
@variablo87 variablo87 requested review from AriParkkila and removed request for a team February 28, 2020 14:13
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2020

@ARMmbed/mbed-os-wan Please review the latest update

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2020

CI started

@0xc0170 0xc0170 changed the title release _semaphore only once Cellular: release _semaphore only once Mar 5, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 5, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit c17f32f into ARMmbed:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cellular Context semaphore release twotimes
5 participants
@variablo87 @ciarmcom @0xc0170 @mbed-ci @AriParkkila