-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimal-printf stack overflow #12508
Conversation
@evedon, thank you for your changes. |
Please fix the style (see astyle failures) |
caf20e7
to
a02f4b4
Compare
astyle issue fixed. |
CI started |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
@0xc0170 Can you restart CI for cloud-client-test please as I don't think it is related to my PR? |
I restarted the client test. There is an issue somewhere, reported few days back. I am trying to find out the status today as it has been still failing recently |
Client restarted |
Restarted again, the test was disabled until its fixed, tracked internally. |
Summary of changes
In nightly test, mbed-os-example-crash-reporting fails on GCC_ARM when linking with minimal-printf due to a stack overflow. The fix is to allocate the two
int2hex
arrays inmbed_minimal_formatted_string_hexadecimal
from the heap instead of the stack.The test now passes although the amount of stack left in the main thread is minimal.
Impact of changes
Fix mbed-os-example-crash-reporting nightly test.
Migration actions required
None
Documentation
N/A
Pull request type
Test results
Reviewers