Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFM32: RTCC bugfix for #12374 #12509

Merged

Conversation

stevew817
Copy link
Contributor

RTC unit tests were failing on devices that use RTCC for both RTC and LP Ticker implementation.

Summary of changes

Now using an RTCC retention register to keep track of user timebase for RTC API. RTC and LP Ticker implementations use the same counter, but they shouldn't share timebases.

Closes #12374.

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@amq


Use an RTCC retention register to keep track of user timebase for RTC API. RTC and LP Ticker implementations use the same counter, but they shouldn't share timebases.
@ciarmcom ciarmcom requested a review from a team February 25, 2020 12:00
@ciarmcom
Copy link
Member

@stevew817, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Bugfix for #12374 EFM32: RTCC bugfix for #12374 Feb 25, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Feb 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

client test was restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2020

I had to restarted again client test, was green but failed in jenkins somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFM32: RTC test fails
5 participants