-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFM32: RTCC bugfix for #12374 #12509
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
SiliconLabs:bugfix/rtcc_lpticker_coexistence
Feb 27, 2020
Merged
EFM32: RTCC bugfix for #12374 #12509
0xc0170
merged 1 commit into
ARMmbed:master
from
SiliconLabs:bugfix/rtcc_lpticker_coexistence
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an RTCC retention register to keep track of user timebase for RTC API. RTC and LP Ticker implementations use the same counter, but they shouldn't share timebases.
@stevew817, thank you for your changes. |
amq
approved these changes
Feb 25, 2020
0xc0170
approved these changes
Feb 25, 2020
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
client test was restarted |
I had to restarted again client test, was green but failed in jenkins somewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTC unit tests were failing on devices that use RTCC for both RTC and LP Ticker implementation.
Summary of changes
Now using an RTCC retention register to keep track of user timebase for RTC API. RTC and LP Ticker implementations use the same counter, but they shouldn't share timebases.
Closes #12374.
Documentation
None
Pull request type
Test results
Reviewers
@amq