Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InterruptIn deprecated APIs #12518

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Feb 26, 2020

Summary of changes

Removed InterruptIn deprecated APIs.

Impact of changes

Breaking change: InterruptIn rise and fall methods with cv-qualifiers have been deprecated since Mbed OS 5.1 and they are removed now.

Migration actions required

Use rise(callback(obj, method)) and fall(callback(obj, method))

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @bulislaw


@ciarmcom ciarmcom requested review from bulislaw, evedon and a team February 26, 2020 14:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@bulislaw @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 27, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

With these changes, InterruptIn rise and fall APIs with cv-qualifiers sources are removed and this is the breaking changes for the user

I would update this to:

Breaking change: InterruptIn rise and fall methods with cv-qualifiers has been deprecated since Mbed OS 5.1 and are removed now.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Feb 27, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 27, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

Client restarted

@0xc0170 0xc0170 merged commit c250781 into ARMmbed:master Feb 27, 2020
@mergify mergify bot removed the ready for merge label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants