Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit include of mbedtls/config.h #12521

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Remove explicit include of mbedtls/config.h #12521

merged 1 commit into from
Mar 2, 2020

Conversation

kivaisan
Copy link
Contributor

Summary of changes

Including mbedtls/config.h should not be done explicitely. This prevents using MBEDTLS_CONFIG_FILE macro.
Correct config file is automatically included by other mbedtls header files.

Impact of changes

None

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila @VeijoPesonen

Remove explicit include of mbedtls/config.h
29affbc 
Including mbedtls/config.h should not be done explicitely. This prevents using MBEDTLS_CONFIG_FILE macro.
Correct config file is automatically included by other mbedtls header files.
@ciarmcom ciarmcom requested review from AnttiKauppila, VeijoPesonen and a team February 27, 2020 08:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@AnttiKauppila @VeijoPesonen @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 27, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Feb 27, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 27, 2020

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 merged commit c2c6d25 into ARMmbed:master Mar 2, 2020
@mergify mergify bot removed the ready for merge label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@AnttiKauppila AnttiKauppila Awaiting requested review from AnttiKauppila

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kivaisan @ciarmcom @0xc0170 @mbed-ci @SeppoTakalo @VeijoPesonen