Bugfix: Concurrent SFDP header address init fixed #12524
Conversation
|
@VeijoPesonen, thank you for your changes. |
|
Rebased. "needs: preceding PR"-label can be removed. |
|
CI was started |
|
I approved although I question if these one liners in the commit messages are sufficient for changes here (there is one "refactor" that is asking for more details if it is refactor?). |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
Combines implementations found from SPIFBlockDevice and QSPIFBlockDevice and makes it as part of the SFDP module.
Takes implementations found from SPIFBlockDevice and QSPIFBlockDevice and makes those as part of the SFDP module.
After switching from local variables to shared info structure JEDEC Basic Flash Parameter Table and Sector Map Parameter Table addresses and sizes must be protected by a mutex. Theoretically multiple calls to Q/SPIFBlockDevice might occur.
Doxygen documentation was updated. Code reorganized to make it more readable. Moves SFDP specific bits out from Q/SPIFBlockDevices.
To follow the same convention as with QSPIFBlockDevice there was need to create a separate function for handling vendor specific workarounds.
mergify
bot
dismissed stale reviews from SeppoTakalo and 0xc0170
Pull request has been modified.
Descriptions expanded. |
|
CI restarted |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
Restarting entire pipeline, there was a fix to master to fix tests failing here. |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
Client restarted |
1 similar comment
|
Client restarted |
Summary of changes
Depends on PR #12450[merged].After switching from local variables to shared info structure JEDEC Basic Flash Parameter Table and Sector Map Parameter Table addresses and sizes must be protected by a mutex. Theoretically multiple calls to Q/SPIFBlockDevice might occur. This is not a critical issue because normally application shouldn't end up calling init() concurrently. Hence I haven't split this bugfix into it's own PR.
Consolidation of SFDP header and table parsing continues.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@SeppoTakalo