Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: scancode ret value not cat fix #12529

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 27, 2020

Summary of changes

This fixes the status like this: "travis-ci/licence_check — Needs review, 0 license issues found"

I was wondering why I can see it in new PRs. Because my last change to the travis made this possible, retval from cat was checked, not from scancode itself.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 27, 2020 18:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 27, 2020

Needs review, 0 license issues found

OK, have to fix it still 👀

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 28, 2020

I am adding some debug prints to travis to figure out why the ret value has unexpected value

Fix to properly evaluate the findings - read the logs to get how many files there are reported.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 28, 2020

I missed one print in there, removed. It should be fixed now and report properly the license count.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 2, 2020

Travis restarted and CI started

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 3, 2020

I noticed the status was not set as I fixed the return code, pushed an update to address this. I'll restart CI

@0xc0170 0xc0170 merged commit 32e8b2f into ARMmbed:master Mar 3, 2020
@0xc0170 0xc0170 deleted the fix_scancode_ret branch March 3, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants