-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: scancode ret value not cat fix #12529
Conversation
@0xc0170, thank you for your changes. |
OK, have to fix it still 👀 |
I am adding some debug prints to travis to figure out why the ret value has unexpected value |
d691b81
to
7402d2f
Compare
7402d2f
to
915e2e1
Compare
Fix to properly evaluate the findings - read the logs to get how many files there are reported.
915e2e1
to
3c441eb
Compare
I missed one print in there, removed. It should be fixed now and report properly the license count. |
Travis restarted and CI started |
I noticed the status was not set as I fixed the return code, pushed an update to address this. I'll restart CI |
Summary of changes
This fixes the status like this: "travis-ci/licence_check — Needs review, 0 license issues found"
I was wondering why I can see it in new PRs. Because my last change to the travis made this possible, retval from cat was checked, not from scancode itself.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers