Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated CallChain class and its APIs #12534

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Remove the deprecated CallChain class and its APIs #12534

merged 1 commit into from
Mar 3, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Feb 28, 2020 •
edited
Loading

Summary of changes

CallChain is never intended for public use and its no longer used in Mbed OS, therefore, it is removed.

Impact of changes

Breaking change: CallChain class and its methods have been deprecated since Mbed OS 5.6 and they are removed now.

Migration actions required

None

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @bulislaw

@mergify mergify bot added the needs: CI label Feb 28, 2020
@rajkan01 rajkan01 changed the title Remove the deprecated CallChain class and its APIs. Remove the deprecated CallChain class and its APIs Mar 2, 2020
@0xc0170 0xc0170 requested a review from bulislaw March 2, 2020 16:40
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 2, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 3, 2020

client restared

bulislaw
bulislaw suggested changes Mar 3, 2020
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Migration actions required
None

Please say that it wasn't part of public Mbed API as in the other PR we talked about.

bulislaw
bulislaw approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, it's in the description.

@0xc0170 0xc0170 merged commit 6e6603f into ARMmbed:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajkan01 @0xc0170 @mbed-ci @bulislaw @evedon