Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threads: fix timeout (set to 25) #12545

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 2, 2020

Summary of changes

This fixes latest master testing (affects all Prs as of today), we should review and integrate asap.

To fix this issue: [1583145599.75][HTST][INF] test suite run finished after 20.04 sec...

Increase to leave some margin. This was observed in the latest master today with multiple
targets.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ARMmbed/mbed-os-core

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 2, 2020

The test currently takes ~20 seconds, at its limit so failing often this week.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 2, 2020

I started CI to confirm this fixes it

@0xc0170 0xc0170 requested a review from jamesbeyond March 2, 2020 12:28
@0xc0170 0xc0170 force-pushed the fix_threads_timeout branch 2 times, most recently from 822bd17 to 8ec2970 Compare March 2, 2020 12:38
@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 2, 2020

I accidentally pushed , so have to restart testing

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the timeout was a bit short

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit d52f55e into ARMmbed:master Mar 2, 2020
@0xc0170 0xc0170 deleted the fix_threads_timeout branch March 2, 2020 16:12
@mergify mergify bot removed the ready for merge label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants