Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++11-ify NonCopyable #12571

Merged
merged 1 commit into from
Mar 12, 2020
Merged

C++11-ify NonCopyable #12571

merged 1 commit into from
Mar 12, 2020

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Mar 4, 2020

Summary of changes

Define copy operators public and deleted rather declaring them private and undefined. Will give immediate compilation errors rather than delayed linking errors.

Impact of changes

Migration actions required

None.

Documentation

None.

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team March 4, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 4, 2020

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@pea-pod
Copy link
Contributor

pea-pod commented Mar 4, 2020

The doc-comments are now out of date. See comments.

@kjbracey
C++11-ify NonCopyable
489525c 
Define copy operators public and deleted rather declaring them private
and undefined. Will give immediate compilation errors rather than
delayed linking errors.
pea-pod
pea-pod suggested changes Mar 5, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 5, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 5, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 5, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@adbridge
Copy link
Contributor

There are known client issues in CI so will try rerunning this

@mbed-ci
Copy link

mbed-ci commented Mar 11, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 0699ac4 into ARMmbed:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pea-pod pea-pod pea-pod requested changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kjbracey @ciarmcom @pea-pod @0xc0170 @mbed-ci @adbridge @evedon