Change Mutex lock and unlock APIs return value to void #12598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evedon
previously requested changes
Mar 9, 2020
rajkan01
force-pushed
the
mutex_lock_remove_return
branch
from
ed5a921 to
8603d2b
Compare
evedon
previously approved these changes
Mar 9, 2020
kjbracey
reviewed
Mar 10, 2020
rtos/Mutex.h
Outdated
| @note You cannot call this function from ISR context. | ||
| @note This function treats RTOS errors as fatal system errors, so it can only return osOK. | ||
| Use of the return value is deprecated, as the return is expected to become void in the future. | ||
| @note This function treats RTOS errors as fatal system errors, so it might not return. |
There was a problem hiding this comment.
"It might not return" sounds a bit odd. I can't think of a better phrase to substitute. I think I'd be tempted to just stop at the comma, or maybe drop the note altogether.
It was only really to explain that people shouldn't be looking at the return code, and I don't think it's needed any more.
rajkan01
force-pushed
the
mutex_lock_remove_return
branch
from
d22b90d to
b67258e
Compare
rajkan01
force-pushed
the
mutex_lock_remove_return
branch
from
b67258e to
30852be
Compare
|
@kjbracey-arm could you please review the updates thanks. |
|
CI started in the interim |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
kjbracey
previously approved these changes
Mar 10, 2020
|
CI restarted |
Test run: FAILEDSummary: 1 of 8 test jobs failed Failed test jobs:
|
evedon
approved these changes
Mar 10, 2020
|
CI restarted |
Test run: SUCCESSSummary: 8 of 8 test jobs passed |
|
This PR does not contain release version label after merging. |
mergify
bot
added
the
release version missing
0xc0170
removed
the
release version missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Modified Mutex lock() and unlock() APIs to return
voidas return status value deprecated.Impact of changes
Breaking change: Mutex
lock()andunlock()methods return status value have been deprecated since Mbed OS 5.9, so changed the return value tovoid.Migration actions required
Use Mutex
void lock(),void unlock()methods.Documentation
None
Pull request type
Test results
Reviewers
@evedon