Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RtosTimer deprecated class #12601

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Mar 9, 2020

Summary of changes

Removed RtosTimer deprecated class.

Impact of changes

Breaking change: RtosTimer has been deprecated since Mbed OS 5.2 and it is removed now.

Migration actions required

Use EverntQueue as it provides similar functionality with the additional features to handle deferring other events to multiple contexts.

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


@adbridge
Copy link
Contributor

@rajkan01 How can this not affect documentation? At best the old API needs to be removed and shouldn't there be some guidance in the docs on what to do instead ?

@adbridge
Copy link
Contributor

CI started

@rajkan01
Copy link
Contributor Author

@rajkan01 How can this not affect documentation? At best the old API needs to be removed and shouldn't there be some guidance in the docs on what to do instead ?

@adbridge RtosTimer documentation is generated from Doxygen comment. We have already described in Migration action required section about the replacement.

@iriark01
Copy link
Contributor

It would probably be helpful to replace the content of the API page with a deprecation note and link to relevant information. @AnotherButler what do you think? You know RTOS better than I do.

@mergify mergify bot added needs: work and removed needs: CI labels Mar 10, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 10, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 10, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@AnotherButler
Copy link
Contributor

We haven't had this page in our documentation since 5.11.

@adbridge
Copy link
Contributor

CI restarted

@mergify mergify bot added needs: CI and removed needs: work labels Mar 11, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 11, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 3
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants