-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HRM1017, TY51822R3, SSCI824 files. #12697
Conversation
Can you amend the commit message (a reason for removal of these targets?) ? |
@Shinichi-Ohki, thank you for your changes. |
Hi, I add a commit message in the pull request. Thanks. |
Thanks for the update, can you rebase to remove merge commit ( I can see also some styling changes in targets.json, is this because of that merge commit , or was it done intentionally as part of another change?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean the git history (removing merge commit) and styling changes as part of another commit need review
f564120
to
4b70603
Compare
@0xc0170 We have updated the commit. Please can you review. |
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
I'll restart tests later today |
CI restarted |
Test run: FAILEDSummary: 2 of 3 test jobs failed Failed test jobs:
|
@Shinichi-Ohki Can you please remove this macro too? (only for the mbed-os/targets/TARGET_NXP/mbed_rtx.h Line 80 in 7fce7f5
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
…d OS 6 [Switch Science] Removed SSCI824 from mbed_rtx.h
@Shinichi-Ohki I confirmed the change. Than you! |
@0xc0170 We have updated the commit and rebased. Please can you review. |
there are few other PRs that are changing targets.json file, one more will be merged soon, so lets wait and rebase later today to get into CI and merge asap. Sorry about conflicts, there are few removals outstanding. |
@Shinichi-Ohki I realize we introduce many changes that conflict with files in this PR. |
I believe we should or take over this one and resolve conflicts 👍 |
Changes have been introduced in #12864 |
Summary of changes
[Switch Science] Deprecate and clean up unsupported platforms for Mbed OS 6
Remove HRM1017, TY51822R3 and SSCI824 files for Mbed OS 6 update.
Remove HRM1017, TY51822R3, SSCI824 section from target.json.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers