Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HRM1017, TY51822R3, SSCI824 files. #12697

Closed
wants to merge 1 commit into from

Conversation

Shinichi-Ohki
Copy link

@Shinichi-Ohki Shinichi-Ohki commented Mar 25, 2020

Summary of changes

[Switch Science] Deprecate and clean up unsupported platforms for Mbed OS 6

Remove HRM1017, TY51822R3 and SSCI824 files for Mbed OS 6 update.
Remove HRM1017, TY51822R3, SSCI824 section from target.json.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

Can you amend the commit message (a reason for removal of these targets?) ?

@ciarmcom ciarmcom requested review from maclobdell and a team March 25, 2020 14:00
@ciarmcom
Copy link
Member

@Shinichi-Ohki, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@Shinichi-Ohki
Copy link
Author

Hi, I add a commit message in the pull request.
'[Switch Science] Deprecate and clean up unsupported platforms for Mbed OS 6'

Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

Thanks for the update, can you rebase to remove merge commit ( I can see also some styling changes in targets.json, is this because of that merge commit , or was it done intentionally as part of another change?).

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean the git history (removing merge commit) and styling changes as part of another commit need review

@mergify mergify bot dismissed 0xc0170’s stale review March 30, 2020 04:06

Pull request has been modified.

@nobonobo nobonobo force-pushed the ssci branch 2 times, most recently from f564120 to 4b70603 Compare March 30, 2020 23:02
@Shinichi-Ohki
Copy link
Author

@0xc0170 We have updated the commit. Please can you review.

0xc0170
0xc0170 previously approved these changes Apr 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

I'll restart tests later today

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@toyowata
Copy link
Contributor

@Shinichi-Ohki Can you please remove this macro too? (only for the || defined (TARGET_SSCI824))

#elif defined(TARGET_LPC824) || defined(TARGET_SSCI824)

@mergify
Copy link

mergify bot commented Apr 15, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

…d OS 6

[Switch Science] Removed SSCI824 from mbed_rtx.h
@toyowata
Copy link
Contributor

@Shinichi-Ohki I confirmed the change. Than you!

@Shinichi-Ohki
Copy link
Author

@0xc0170 We have updated the commit and rebased. Please can you review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2020

there are few other PRs that are changing targets.json file, one more will be merged soon, so lets wait and rebase later today to get into CI and merge asap. Sorry about conflicts, there are few removals outstanding.

@MarceloSalazar
Copy link

@Shinichi-Ohki I realize we introduce many changes that conflict with files in this PR.
Do you mind if we pick the changes here and introduce them as part of this PR? #12864

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2020

Do you mind if we pick the changes here and introduce them as part of this PR? #12864

I believe we should or take over this one and resolve conflicts 👍

@MarceloSalazar
Copy link

Changes have been introduced in #12864
Closing this PR - thanks for your help on removing these targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants