Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress: Partial backport of #12769 #12771

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Cypress: Partial backport of #12769 #12771

merged 1 commit into from
Apr 8, 2020

Conversation

kyle-cypress
Copy link

Summary of changes

Remove an assert from get_rssi() in WhdSTAInterface.cpp which causes rssi greentea test to fail in Cypress parts. This is because the RSSI GT test expect the negative test case to return 0 and not assert.
This is a backport of 0504873 from #12769

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

GT_FT_KIT_EVB_43012_GCC-NET.txt
GT_FT_P6S1_43012EVB_01_GCC_NET.txt
GT_FT_PROTO_062S3_4343W_GCC_NET.txt
GT-FT-KIT_062_WIFI_BT-GCC-NET.txt
GT-FT-KIT-062S2-43012-GCC-NET.txt
GT-FT-PROT-062-4343W-GCC-NET.txt

The failure of test-network-wifi on CY8CKIT_062_WIFI_BT is a transient network issue; it did not repeat when the test was rerun manually.

Reviewers

@cypress-midd
WHD: Remove an assert from get_rssi()
d55117f 
This assert in WhdSTAInterface.cpp causes rssi greentea test to fail
on Cypress parts. This is because the rssi GT test expects the negative
test case to return 0 and not assert.
@ciarmcom ciarmcom requested a review from a team April 8, 2020 01:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 8, 2020

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers April 8, 2020 07:00
@mergify mergify bot added needs: CI and removed needs: review labels Apr 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Apr 8, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 8, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

example restarted

@adbridge
Copy link
Contributor

adbridge commented Apr 8, 2020

@0xc0170 this is out of date with the base branch so shouldn't be ready for merge ?

andypowers
andypowers approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 3db7cd4 into ARMmbed:mbed-os-5.15 Apr 8, 2020
@mergify mergify bot removed the ready for merge label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

@andypowers andypowers andypowers approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
release-version: 5.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kyle-cypress @ciarmcom @0xc0170 @mbed-ci @adbridge @andypowers @cypress-midd