Update stm32 emac ethernet driver #12776
Conversation
DISCO_F769NI EMAC driver may return ethernet packet with illegal length when driver is under heavy load. In one case, the received bytes indicate frame length of 53 bytes but advertised data length was 65518 bytes. In another case EMAC driver variable `EthHandle.RxFrameInfos.length` contained value 0xFFFF FFFC. As a work-around accept only 1-1500 bytes long ethernet packets.
-Fix len type -Use ETH_RX_BUF_SIZE instead of hard-coded value 1500
@JarkkoPaso could you please chat to @artokin about whether this is actually needed ? |
|
@artokin is not available before Tuesday. |
There was a problem hiding this comment.
Change is already present on master, and I see no reason not to backport it. If you want to argue that it should be removed from master, that's a separate discussion.
The nonsense-length error certainly has been seen in the past, and if it happens it is system fatal. Seems the right thing to do to maintain a 1-comparison safety check there until the reason for the original error is understood.
The failure to reproduce during the #12459 discussion could be down to some alignment precondition like that recent sleep crash thing.
|
CI started |
|
CI aborted ,another job started (will clean the statuses after the current completes so do not clear any new one) |
Test run: FAILEDSummary: 3 of 3 test jobs failed Failed test jobs:
|
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
Summary of changes
DISCO_F769NI EMAC driver may return ethernet packet with illegal length when driver is under heavy load. In one case, the received bytes indicate frame length of 53 bytes but advertised data length was 65518 bytes. In another case EMAC driver variable EthHandle.RxFrameInfos.length contained value 0xFFFF FFFC.
As a work-around accept only 1-1500 bytes long ethernet packets.
Impact of changes
STM EMAC driver will not return long data packets to the application. Packets longer than 1500 bytes are ignored.
Migration actions required
Documentation
Pull request type
Test results
Reviewers