Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert newlines on all terminal (tty) devices by default #12889

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Applications can reduce their ROM usage by replacing
"\r\n" by "\n".

Impact of changes

Breaks compatibility with applications built with Mbed 2.

Migration actions required

Update to the latest version of Mbed OS (possibly using the bare metal profile for ultra-constrained devices).

Documentation

N/A


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @kjbracey-arm


@ciarmcom ciarmcom requested review from evedon, kjbracey and a team April 29, 2020 17:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@evedon @kjbracey-arm @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2020

Based on the change and description, this should be Major update. Marked as breaking

@kjbracey
Copy link
Contributor

Fine apart from description - it's not "all file descriptors". It won't be doing it to a disc file, just terminal devices (whose FileHandle::isatty returns true).

kjbracey
kjbracey previously approved these changes Apr 30, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Apr 30, 2020
evedon
evedon previously approved these changes Apr 30, 2020
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugueskamba please address Kevin's comment. Otherwise PR is fine.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

CI started

Applications can reduce their ROM usage by replacing
"\r\n" by "\n".
@hugueskamba hugueskamba changed the title Convert newlines on all file descriptors by default Convert newlines on all terminal (tty) devices by default Apr 30, 2020
@mergify mergify bot dismissed stale reviews from kjbracey and evedon April 30, 2020 10:01

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

CI aborted, and restarted

@hugueskamba
Copy link
Collaborator Author

This force-push amends the commit message.

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

The above is from aborted built, the new one is going fine.

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 32ea606 into ARMmbed:master Apr 30, 2020
@hugueskamba hugueskamba deleted the hk_stdio_config branch April 30, 2020 12:54
@mergify mergify bot removed the ready for merge label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants