Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added kv store adaptation to nanostack file interface (Mbed OS 5.15) #12895

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Added kv store adaptation to nanostack file interface (Mbed OS 5.15) #12895

merged 1 commit into from
Jun 8, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

This is port of #12878 to Mbed OS 5.15

Added NS filesystem API module to mbed-os Nanostack HAL. Module provides kv_store interface for the Nanostack. Feature is disabled by default on .json configuration.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin @juhhei01 @JarkkoPaso

@ciarmcom ciarmcom requested review from artokin, JarkkoPaso, juhhei01, mikter and a team April 30, 2020 07:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@JarkkoPaso @artokin @juhhei01 @mikter @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 30, 2020
@0xc0170 0xc0170 requested a review from andypowers May 7, 2020 13:57
@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 7, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020 •
edited
Loading

Waiting for @andypowers review

@adbridge
Copy link
Contributor

@0xc0170 why did you add needs: review and remove release review required? The latter is required until the PR is accepted for this branch.

andypowers
andypowers approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit f2b0cda into ARMmbed:mbed-os-5.15 Jun 8, 2020
@mergify mergify bot removed the ready for merge label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikter mikter mikter approved these changes

@artokin artokin artokin approved these changes

@andypowers andypowers andypowers approved these changes

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@juhhei01 juhhei01 Awaiting requested review from juhhei01

Assignees
No one assigned
Labels
release-version: 5.15.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mikaleppanen @ciarmcom @0xc0170 @mbed-ci @adbridge @mikter @artokin @andypowers