Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt1250 enable tac info for registration status (mbed 5.15) #12972

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Alt1250 enable tac info for registration status (mbed 5.15) #12972

merged 1 commit into from
Jun 8, 2020

Conversation

kivaisan
Copy link
Contributor

Summary of changes

ALT1250 supports tac info in registration status, so this commit enables the feature.

Impact of changes

CellularNetwork::get_registration_params can now return cell info.

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

Cellular: Enable tac info for ALT1250
5de677a 
ALT1250 supports tac info in registration status, so this commit enables the feature.
@ciarmcom ciarmcom requested a review from a team May 14, 2020 13:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from andypowers May 15, 2020 08:20
@mergify mergify bot added needs: CI and removed needs: review labels May 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 3, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 599ddce into ARMmbed:mbed-os-5.15 Jun 8, 2020
@mergify mergify bot removed the ready for merge label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kivaisan @ciarmcom @0xc0170 @mbed-ci @andypowers @jarvte