Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: Add tx power control to cordio HCI driver #13040

Merged
merged 2 commits into from
Jun 16, 2020
Merged

BLE: Add tx power control to cordio HCI driver #13040

merged 2 commits into from
Jun 16, 2020

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

Adds a new optional call to the CordioHCIDriver. This exposes controller support for setting TX power. This may or may not be implemented by each board. An error code for unimplemented feature will be returned if it's not present.

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@paul-szczepanek-arm paul-szczepanek-arm changed the title [BLE] Add tx power control to cordio hci driver [BLE] Add tx power control to cordio HCI driver May 29, 2020
@ciarmcom
Copy link
Member

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from pan- and a team May 29, 2020 19:00
pan-
pan- approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. It would be good to have review from an ST maintainer.
@ARMmbed/mbed-os-maintainers Can you help with that ?

@paul-szczepanek-arm paul-szczepanek-arm changed the title [BLE] Add tx power control to cordio HCI driver BLE: Add tx power control to cordio HCI driver Jun 3, 2020
0xc0170
0xc0170 previously approved these changes Jun 9, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Jun 10, 2020

Command refresh: success

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

I merged another related PR, this is now in conflict with master.

@mergify
Copy link

mergify bot commented Jun 10, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

felipeLeast
felipeLeast reviewed Jun 10, 2020
View reviewed changes
features/FEATURE_BLE/targets/TARGET_STM/TARGET_STM32WB/HCIDriver.cpp Outdated
Comment on lines 136 to 145
const int8_t conversion[] = {
-40, -21 - 10 - 19, -18, -16, -15, -14, -13, -12, -11, -10, -9, -8,
-7, -6, -5, -4, -3, -2, -2, -1, -1, 0, 0, 0, 1, 2, 3, 4, 5, 6,
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it missing commas between -21, -10 and -19? I tested using both ways and with commas the level_db for 6dbm is higher than without comma.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for catching that, that's some copy paste catastrophe, now fixed and double checked against STM32WBx5 application note

@mergify mergify bot dismissed 0xc0170’s stale review June 10, 2020 14:45

Pull request has been modified.

@adbridge
Copy link
Contributor

@felipeLeast @0xc0170 are you guys happy with this now ?

@felipeLeast
Copy link

@felipeLeast @0xc0170 are you guys happy with this now ?

Yes!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 8f87735 into ARMmbed:master Jun 16, 2020
@mergify mergify bot removed the ready for merge label Jun 16, 2020
@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeLeast felipeLeast felipeLeast left review comments

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paul-szczepanek-arm @ciarmcom @0xc0170 @mbed-ci @adbridge @felipeLeast @pan-