Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of KW41Z Nanostack driver #13230

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Jul 3, 2020

Summary of changes

In #13119 we moved Nanostack target drivers into nanostack-interface/targets, to fix issues with bare-metal (i.e. no mbed_lib.json to guard unused libraries). But at roughly the same time, #13115 (rename TARGET_NXP to TARGET_Freescale) was made in the old path. Now we end up with identical KW41Z drivers in two different places.

This PR resolves the issue:

Impact of changes

Migration actions required

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing: both mbed-os-example-blinky and mbed-os-example-blinky-baremetal compile for KW41Z.


Reviewers

@MarceloSalazar @evedon


@ciarmcom ciarmcom requested review from evedon, MarceloSalazar and a team July 3, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 3, 2020

@LDong-Arm, thank you for your changes.
@MarceloSalazar @evedon @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested review from mmahadevan108 and removed request for a team July 6, 2020 07:27
@mergify mergify bot added needs: CI and removed needs: review labels Jul 6, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 6, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: review release-type: patch Indentifies a PR as containing just a patch and removed ready for merge labels Jul 6, 2020
@adbridge adbridge removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants