-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move storage from features into mbed-os root directory #13244
Move storage from features into mbed-os root directory #13244
Conversation
2d7f833
to
30a98ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but we propose to move unit tests from the top-level UNITTESTS into individual libraries. This can happen in a future PR after we have finished refactoring libraries IMO.
A CI run would verify that we haven't missed anything here.
Could this correct #11993? |
- Move mbed-os/features/storage to mbed-os/storage - Move components/storage/blockdevice to storage/blockdevice/COMPONENT_xxx
- Move UNITTESTS/features/storage to UNITTESTS/storage - update the .cmake files to refer the new directory
30a98ac
to
b4dfcae
Compare
b4dfcae
to
3f080df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for a first PR.
UNITTESTS and greentea tests will be sorted in a subsequent PR.
CI started |
I've noticed File https://github.com/ARMmbed/mbed-os/blob/3f080dfd650fc9a97280c98742b1209185480383/storage/filesystem/littlefs/TESTS/util/clean.sh has it for instance, visible in the diff here on Github. |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
We are going to soon migrate storage to below new directory structure
This PR Changes:
mbed-os/features/storage
tombed-os/storage
components/storage/blockdevice
tostorage/blockdevice/COMPONENT_xxx
Note:
Impact of changes
None.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Manual testing: (Build for K64F target with ARMC6 toolchain)
Reviewers
@bulislaw @0xc0170 @ARMmbed/mbed-os-core