Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements iterators for the Span class to be compatible with std::span #13252

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

marcemmers
Copy link
Contributor

Summary of changes

Implements iterators for the Span class to be compatible with std::span.
This makes it possible, among other things, to use range based for loops on a span.

Impact of changes

Migration actions required

Documentation

It might be useful to add this to the API reference but its not necessary.


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@mergify mergify bot added the needs: work label Jul 8, 2020
@ciarmcom ciarmcom requested review from a team July 8, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@marcemmers, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jul 9, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Jul 9, 2020
pan-
pan- previously requested changes Jul 9, 2020
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcemmers that is very useful for use in algorithms and range-based for loop. One minor thing, could you include the <iterator> header ?

@mergify mergify bot added needs: work and removed needs: CI labels Jul 9, 2020
@mergify mergify bot dismissed stale reviews from 0xc0170 and pan- July 9, 2020 10:23

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants