Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nanostack-libservice into connectivity/libraries #13254

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Move nanostack-libservice into connectivity/libraries #13254

merged 2 commits into from
Jul 17, 2020

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Jul 8, 2020 •
edited
Loading

Summary of changes

As per our new directory structure proposal, this PR moves nanostack-libservice from features/frameworks into connectivity/libraries.

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

nanostack-border-router compiles for K64F. Unit tests continue to work.

Reviewers

@ARMmbed/mbed-os-core

@ciarmcom ciarmcom requested review from a team July 8, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

rajkan01
rajkan01 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

CI on this ran 8 days ago so re-running

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit f5801aa into ARMmbed:master Jul 17, 2020
@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed ready for merge labels Jul 17, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LDong-Arm @ciarmcom @0xc0170 @mbed-ci @adbridge @pan- @rajkan01 @mbedmain