Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MTS_DRAGONFLY_F411RE bootloader to work with mbed 5 & 6 #13294

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

felser
Copy link
Contributor

@felser felser commented Jul 14, 2020

Summary of changes

Update the MTS_DRAGONFLY_F411RE bootloader so it works with mbed version 6.x.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Tested with mbed 5 and 6 as well as with setting MBED-OS_DIR to point to mbed-os branch 'tools-release-6.0.0' from a directory with mbed-os-5.15.1.

Reviewers


@ciarmcom ciarmcom requested review from a team July 14, 2020 23:00
@ciarmcom
Copy link
Member

@felser, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@felser I'm a little confused here, is this for Mbed 6 or for Mbed 5? Mbed 5 is only supported on the mbed-os-5.15 branch, so if you need an update for that you would have to raise a separate PR against that branch...

@felser
Copy link
Contributor Author

felser commented Jul 17, 2020

The mention of mbed 5 is due to the issue we discovered with our mdot device. When using the online compiler, the mbed 6 tools are used even when an mbed 5 application is being built. This only is for mbed 6.

@maclobdell
Copy link
Contributor

maclobdell commented Jul 17, 2020

@felser - I don't think bootloaders should live in Mbed OS anymore. Can you refactor your target support such that it is not a requirement for the device to boot up? and a bootloader for FOTA such as with Pelion device management can be added in an application example using the managed bootloader support in Mbed OS. Does that make sense to do?

@felser
Copy link
Contributor Author

felser commented Jul 17, 2020

PR #13301 removes the binary hook so mbed_app.json can be used but removal of it caused a problem with the online compiler. Taylor Heck had to add it back in on the mdot. See PR #13135.

@felser
Copy link
Contributor Author

felser commented Jul 22, 2020

Can we get this bootloader updated? If you really do not want it in mbed, there needs to be a solution to the online compiler problem when building mbed 5 apps.

@maclobdell
Copy link
Contributor

maclobdell commented Jul 24, 2020

I see now that this PR is similar to #13135, which added back a bootloader. Can this be merged to resolve the issue in a similar way?

@mergify mergify bot added needs: CI and removed needs: review labels Jul 29, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 29, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 29, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Aug 10, 2020
@0xc0170 0xc0170 merged commit afcefd6 into ARMmbed:master Aug 10, 2020
@mergify mergify bot removed the ready for merge label Aug 10, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants