Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doubly defined symbol from mbed_lib.json #13330

Conversation

rwalton-arm
Copy link
Contributor

Summary of changes

MBEDTLS_CMAC_C already seems to be defined in https://github.com/ARMmbed/mbed-os/blob/master/features/mbedtls/inc/mbedtls/config.h#L2416 - this was causing warnings in CMake builds about multiple defined symbols.

This patch removes the macro from the mbed_lib.json as it seems to be unnecessary.

Impact of changes

Migration actions required

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@mergify mergify bot added the needs: CI label Jul 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0e2d3df into ARMmbed:master Jul 22, 2020
@mergify mergify bot removed the ready for merge label Jul 22, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants