Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuvoton: Update M252 target name #13332

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Nuvoton: Update M252 target name #13332

merged 1 commit into from
Jul 24, 2020

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

To update M252 platform name as NUMAKER_IOT_M252, the purpose is to sync with ARMmbed/mbed-os-tools at (ARMmbed/mbed-os-tools#220)

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2020
@ciarmcom ciarmcom requested a review from a team July 22, 2020 13:00
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

@cyliangtw Is this just a patch, the target has not yet been released ?

@cyliangtw
Copy link
Contributor Author

@0xc0170 Yes, it's a patch and I will send 5 units to UK team in 2 weeks for validation.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 23, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jul 23, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 23, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit f5358a7 into ARMmbed:master Jul 24, 2020
@mergify mergify bot removed the ready for merge label Jul 24, 2020
@ccli8 ccli8 mentioned this pull request Jul 31, 2020
Merged
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
@cyliangtw cyliangtw deleted the nvt_iot_m252_target branch October 5, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyliangtw @ciarmcom @0xc0170 @mbed-ci @mbedmain