Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure netsocket directory #13335

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Restructure netsocket directory #13335

merged 7 commits into from
Jul 27, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jul 22, 2020 •
edited
Loading

Summary of changes

Dependent PR: ARMmbed/esp32-driver#4

Restructured features/netsocket as per the new directory structure proposal:

connectivity
├── netsocket 
│   ├── mbed_lib.json
│   ├── include
│   │   └── netsocket
│   │       └── *.h
│   ├── source
│   └── tests
│       ├── UNITTESTS
│       └── TESTS     // both netsocket & network tests

Impact of changes

None.

Migration actions required

None.

Documentation

To Be Updated.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing: (Build for K64F target with GCC_ARM toolchain)

  • mbed-os-example-sockets
  • Greentea tests: Full profile
  • Unit tests build and run

Reviewers

@0xc0170 @ARMmbed/mbed-os-core

@rajkan01 rajkan01 changed the title Netsocket dir restructure Restructure netsocket directory Jul 22, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2020
@ciarmcom ciarmcom requested review from 0xc0170 and a team July 22, 2020 15:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

UNITTESTS/features/cellular/framework/AT/at_cellularcontext/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/AT/at_cellulardevice/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/AT/at_cellularinformation/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/AT/at_cellularsms/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/AT/at_cellularstack/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/device/cellularcontext/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/device/cellulardevice/unittest.cmake Outdated Show resolved Hide resolved
UNITTESTS/features/cellular/framework/device/cellularstatemachine/unittest.cmake Outdated Show resolved Hide resolved
connectivity/netsocket/tests/UNITTESTS/netsocket/CellularNonIPSocket/unittest.cmake Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Jul 23, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01 rajkan01 requested a review from LDong-Arm July 23, 2020 14:17
@mergify mergify bot added needs: CI and removed needs: work labels Jul 24, 2020
@rajkan01
Copy link
Contributor Author

@0xc0170 This PR is ready for CI. Could you start the CI, please

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Jul 24, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 24, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@rajkan01 rajkan01 mentioned this pull request Jul 27, 2020
Merged
@jamesbeyond
Copy link
Contributor

Hi, @rajkan01 @paul-szczepanek-arm
cc @0xc0170

as I mentioned, in slack, earlier. this PR is dependent on ARMmbed/esp32-driver#4
I believe if ARMmbed/esp32-driver#4 merged, and this one not merged yet, it will cause failure in CI,
So please merged those 2 one after another quickly , and shorten the CI down time.

@rajkan01
Copy link
Contributor Author

@0xc0170 Please restart the CI for this PR as ARMmbed/esp32-driver#4 merged already that will break CI without this PR

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 27, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jul 27, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@rajkan01
Copy link
Contributor Author

@0xc0170 This PR CI passed, could you merge

@0xc0170 0xc0170 merged commit 6bd5271 into ARMmbed:master Jul 27, 2020
@mergify mergify bot removed the ready for merge label Jul 27, 2020
@ashok-rao ashok-rao mentioned this pull request Jul 29, 2020
Merged
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @jamesbeyond @evedon @LDong-Arm @mbedmain