Move emac-drivers from features into connectivity directory #13357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
suggested changes
Jul 27, 2020
rajkan01
force-pushed
the
emac_dir_restructure
branch
from
def68e0
to
99ebc01
Compare
LDong-Arm
reviewed
Jul 27, 2020
connectivity/drivers/emac/README.md
Outdated
| @@ -32,7 +32,7 @@ to control your device. This must be derived from class `EMAC`. | |||
| This API is used by a network stack (or test framework) to control your driver. | |||
|
|
|||
| The EMAC-derived driver would normally be installed in | |||
| features/netsocket/emac-drivers, often in a `TARGET_XXX` directory. | |||
| connectivity/drivers/emac/targets, often in a `TARGET_XXX` directory. | |||
There was a problem hiding this comment.
Suggested change
| connectivity/drivers/emac/targets, often in a `TARGET_XXX` directory. | |
| connectivity/drivers/emac, often in a `TARGET_XXX` directory. |
rajkan01
force-pushed
the
emac_dir_restructure
branch
from
99ebc01
to
80d7404
Compare
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
@LDong-Arm I dropped |
LDong-Arm
approved these changes
Jul 27, 2020
doxyfile_options
Outdated
| */mbed-trace/* \ | ||
| */mbed-coap/* \ | ||
| */nanostack-libservice/* \ | ||
| */mbed-client-randlib/* \ | ||
| */nanostack/sal-stack-nanostack-eventloop/* \ | ||
| */ble/generic/* \ | ||
| */ble/pal/* \ | ||
| */components/802.15.4_RF/* \ | ||
| *connectivity/drivers/802.15.4_RF/* \ |
There was a problem hiding this comment.
Suggested change
| *connectivity/drivers/802.15.4_RF/* \ | |
| */connectivity/drivers/802.15.4_RF/* \ |
just for consistency...
rajkan01
force-pushed
the
emac_dir_restructure
branch
from
80d7404
to
2add706
Compare
|
LGTM |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
0xc0170
approved these changes
Jul 28, 2020
mbedmain
added
release-version: 6.2.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Moved
mbed-os/features/netsocket/emac-driverstombed-os/connectivity/drivers/emacImpact of changes
None.
Migration actions required
None.
Documentation
To be updated
Pull request type
Test results
Manual testing: (Build for K64F target with ARMC6 toolchain)
Reviewers