Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes the memory leak that happens when DNS cache is expired (#13398). The
address
member ofdns_cache
is forgotten to be freed before freeing the struct.I did not run any tests on this change, but it fixed the memory leak I was observing using the
mbed_stats_heap_get()
API. I assume that the scenario of waiting DNS cache expiry is not covered in the tests at all. I checked "Covered by existing mbed-os tests" below but maybe new tests are required to test this scenario.Impact of changes
Migration actions required
Documentation
No update required.
Pull request type
Test results
Reviewers