Skip to content

[feature-wisun] Network interface MAC address set/get #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 14, 2020
Merged

[feature-wisun] Network interface MAC address set/get #13902

merged 13 commits into from
Dec 14, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Nov 11, 2020 •
edited
Loading

Summary of changes

Add method set_mac_address that Application can use to set MAC address to the interface.
Update get_mac_address to return MAC address correctly from EMAC.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Method for adding network interface MAC address
26b322e 
Add method set_mac_address to set network interface MAC address.
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team November 11, 2020 13:30
mikter
mikter previously approved these changes Nov 12, 2020
View reviewed changes
MAC address set/get support for EMAC interface
7155c9a 
Add support to set and get MAC address from EMAC interface.
@artokin artokin changed the title [feature-wisun] Method for changing network interface MAC address [feature-wisun] Network interface MAC address set/get Nov 16, 2020
@mergify mergify bot dismissed mikter’s stale review November 16, 2020 14:11

Pull request has been modified.

mikaleppanen
mikaleppanen approved these changes Nov 16, 2020
View reviewed changes
Review correction: Remove unnecessary method
c81aca4 
Remove unnecessary method: add_ethernet_interface_ns
@artokin artokin requested a review from mikaleppanen November 16, 2020 14:39
mikter
mikter previously approved these changes Nov 16, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Nov 16, 2020
@artokin artokin mentioned this pull request Nov 18, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Nov 24, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 24, 2020

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests-lts
  • jenkins-ci/mbed-os-ci_build-ARM-lts
  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts

Fix unittests
cfc1182 
Use path in "mbed-trace/mbed_trace.h" to keep unittest happy.
@mergify mergify bot dismissed mikter’s stale review November 24, 2020 13:30

Pull request has been modified.

Update EmacTestNetworkStack
6b69421 
-Uncomment get_mac_address
-Document set_mac_address
Remove API changes
6967541 
-Remove Nanostack::add_ethernet_interface API change
-Add get_mac_address to MeshEthernetInterface
mikter
mikter previously approved these changes Nov 27, 2020
View reviewed changes
Update WICED binaries for ARMC6
1145979 
A new method has been added to the NetworkInterface. Therfore WICED
library needs to be rebuild for ARMC6.

Update WICED binaries for:
-MTB_ADV_WISE_1530
-MTB_MXCHIP_EMW3166
-MTB_USI_WM_BN_BM_22
@mergify mergify bot dismissed mikter’s stale review November 30, 2020 14:14

Pull request has been modified.

@adbridge
Copy link
Contributor

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Dec 11, 2020
@mbed-ci
Copy link

mbed-ci commented Dec 11, 2020

Test run: FAILED

Summary: 2 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts
  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@adbridge adbridge closed this Dec 11, 2020
@adbridge adbridge reopened this Dec 11, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2020

I restarted Travis, it should be green .

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2020

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 84d9913 into ARMmbed:feature-wisun Dec 14, 2020
@mergify mergify bot removed the ready for merge label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikter mikter mikter left review comments

+3 more reviewers

@juhhei01 juhhei01 juhhei01 approved these changes

@JarkkoPaso JarkkoPaso JarkkoPaso approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@artokin @ciarmcom @0xc0170 @mbed-ci @adbridge @juhhei01 @JarkkoPaso @mikter @mikaleppanen