STM32: LPUART clock source selection up to a serial driver #13929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@JeanMarcR, thank you for your changes. |
JeanMarcR
force-pushed
the
DEEP_SLEEP
branch
from
e8cc5fa to
00e27f0
Compare
|
@jeromecoutant |
jeromecoutant
suggested changes
Nov 23, 2020
| #endif | ||
| PeriphClkInitStruct.Lpuart1ClockSelection = RCC_LPUART1CLKSOURCE_LSE; | ||
|
|
There was a problem hiding this comment.
and endif after HAL_RCCEx_PeriphCLKConfig call ?
0xc0170
changed the title
|
@JeanMarcR I fixed the title, please do not use all-capital title. |
The clock source selection of LPUART depends on System clocks but also on the serial baudrate. There is a specific computation done in serial driver targets/target_STM/serial_api.c At first start-up the LPUART1 clock selected in SetSysClock was anyway overridden by the serial driver, so this was of no effect. But in case of deep sleep SetSysClock is called again, while the driver isn't, so SetSyClock was corrupting the serial clock configuration. So let's remove these few lines of code which are causing trouble. For targets L496 and L5. Taking into account device TRNG in L5 configuration
JeanMarcR
force-pushed
the
DEEP_SLEEP
branch
from
00e27f0 to
41ed923
Compare
jeromecoutant
approved these changes
Nov 23, 2020
|
@jeromecoutant |
0xc0170
approved these changes
Nov 30, 2020
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
jenkins-ci/dynamic-memory-usage — internal error, I'll merge as the job was excluded yesterday |
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clock source selection of LPUART depends on System clocks but also on
the serial baudrate. There is a specific computation done in serial driver
targets/target_STM/serial_api.c
At first start-up the LPUART1 clock selected in SetSysClock was anyway
overridden by the serial driver, so this was of no effect. But in case
of deep sleep SetSysClock is called again, while the driver isn't, so
SetSyClock was corrupting the serial clock configuration.
So let's remove these few lines of code which are causing trouble.
For targets L496 and L5.
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers