Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Set required toolchain and processor flags globally, instead of per-target #13987
CMake: Set required toolchain and processor flags globally, instead of per-target #13987
Changes from all commits
78be77e
6da2cbb
bb7391a
a942b2e
423e8b0
f07c0cd
0972738
3628802
975a871
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to introduce own list for each FLAGS?
MBED_TOOLCHAIN_<LANG>_FLAGS
so C/CXX/ASM/LD, and we would add these to CMake _INIT flags.These could be cached variable, similar as _INIT flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's already how I have it set up.
link_options
is for linker flags,common_options
is for all compilers,c_cxx_compile_options
is for C and CXX compilers, andasm_compile_options
is for ASM only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct the use is as it should. we use
mbed
prefix (MBED_TOOLCHAIN
or so), if these could be prefixed as well but they might not, see my comment belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As these are not global symbols, it does not need to be prefixed neither with capital letters