Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GattAuthCallbackReply_t enumeration. #14014

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented Dec 8, 2020

Summary of changes

Add missing values that are present in pal::AttErrorResponse.
This allows applications to use correct ATT error codes.

The values have been changed to reflect what is actually defined in the specification. The 0x01 was a leftover from softdevice's days.

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Add missing values that are present in pal::AttErrorResponse.
This allows applications to use correct ATT error codes.
@ciarmcom
Copy link
Member

ciarmcom commented Dec 8, 2020

@pan-, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't this be a patch type PR? doesn't actually change the API. It even keeps the old names so will not break existing code.

@pan-
Copy link
Member Author

pan- commented Dec 8, 2020

I followed the definition of Feature update: New feature / Functionality change / New API as there is new enumeration values. But it felt like a patch update.

@0xc0170 Any guidance ?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Dec 10, 2020
@mbed-ci
Copy link

mbed-ci commented Dec 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants