-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GattAuthCallbackReply_t enumeration. #14014
Conversation
Add missing values that are present in pal::AttErrorResponse. This allows applications to use correct ATT error codes.
@pan-, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't this be a patch type PR? doesn't actually change the API. It even keeps the old names so will not break existing code.
I followed the definition of Feature update: @0xc0170 Any guidance ? |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Add missing values that are present in pal::AttErrorResponse.
This allows applications to use correct ATT error codes.
The values have been changed to reflect what is actually defined in the specification. The
0x01
was a leftover from softdevice's days.Documentation
None
Pull request type
Test results
Reviewers