Workaround for Cortex-M33 Arm toochain linking #14401

LDong-Arm · 2021-03-09T17:44:19Z

Summary of changes

Binaries generated for Cortex-M33 targets (e.g. Musca S1/B1) using the Arm toolchain + CMake are unable to run, unless we pass --cpu=... to the linker.

Note: This is a workaround, because

Ideally, the Arm linker should be able to auto detect the architecture support from the input object files, without having to explicitly pass --cpu but it's not always the case. We already have a similar workaround for Cortex-M4 (6220ca5).
The full option to use should be --cpu=Cortex-M33.no_dsp.no_fp but no_dsp currently conflicts with CMake's compilation tests (no option to disable DSP in the dummy test app, before linking stage).

Impact of changes

Applications compiled with mbed-tools/CMake + the Arm toolchain are now able to run on Musca S1 and B1.

Migration actions required

None.

Documentation

None.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @hugueskamba

Binaries generated for Cortex-M33 targets (e.g. Musca S1/B1) using the Arm toolchain + CMake is unable to run, unless we instruct the linker to not use floating points. Note: This is a temporary workaround, because * Ideally, the Arm linker should be able to auto detect the architecture support from the input object files, but it's not always the case. We already have a similar workaround for Cortex-M4. * The full option to use should be `--cpu=Cortex-M33.no_dsp.no_fp` but `no_dsp` currently conflicts with CMake's compilation tests (no option to disable DSP in the test objects before linking).

LDong-Arm · 2021-03-09T18:00:04Z

tools/cmake/cores/Cortex-M33-NS.cmake

+        # the architecture from the objectfiles correctly.
+        # Also, the complete flag should be "--cpu=Cortex-M33.no_dsp.no_fp"
+        # but this currently conflicts with CMake's compiler test until fixed
+        "--cpu=Cortex-M33.no_fp"


@0xc0170 This works, as long as no_dsp is not there.

Similar change for Cortex-M4 made by ST:

mbed-os/tools/cmake/cores/Cortex-M4.cmake

Lines 15 to 19 in 0e89f9d

#Necessary as the linker does not always detect

#the architecture from the objectfiles correctly.

list(APPEND link_options

"--cpu=Cortex-M4.no_fp"

)

ciarmcom · 2021-03-09T18:00:16Z

@LDong-Arm, thank you for your changes.
@hugueskamba @evedon @ARMmbed/mbed-os-maintainers please review.

evedon

Seems reasonnable to apply the same patch as for Cortex-M4

hugueskamba

...(no option to disable DSP in the dummy test app, before linking stage).

Can you please raise an issue on https://gitlab.kitware.com/cmake/cmake/-/issues ?
Thanks

LDong-Arm · 2021-03-10T11:23:10Z

Can you please raise an issue on https://gitlab.kitware.com/cmake/cmake/-/issues ?
Thanks

Thanks, will do 👌

adbridge · 2021-03-10T13:39:16Z

CI started

LDong-Arm · 2021-03-10T14:13:06Z

Looks like there's a CI issue:

Exited https://jenkins-mbedos.oss.arm.com/job/mbed-os-ci_unittests with result org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

adbridge · 2021-03-10T14:53:33Z

@LDong-Arm yup, Saheer managed to temporarily break it. I will restart.

mbed-ci · 2021-03-10T14:55:33Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	❌
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-greentea-ARM	❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-example-ARM	❌

mbed-ci · 2021-03-10T15:26:48Z

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌
jenkins-ci/mbed-os-ci_build-greentea-ARM	❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-example-ARM	❌
jenkins-ci/mbed-os-ci_unittests	❌

LDong-Arm · 2021-03-11T09:18:38Z

@0xc0170
Can we restart CI on this? The CI issue was fixed towards the end of yesterday.
We'd like to have this PR in the release, thanks.

0xc0170 · 2021-03-11T10:22:50Z

CI restarted

mbed-ci · 2021-03-11T10:54:06Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

LDong-Arm · 2021-03-11T13:04:38Z

...(no option to disable DSP in the dummy test app, before linking stage).

Can you please raise an issue on https://gitlab.kitware.com/cmake/cmake/-/issues ?
Thanks

There's an existing issue: https://gitlab.kitware.com/cmake/cmake/-/issues/21173

LDong-Arm commented Mar 9, 2021

View reviewed changes

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 9, 2021

ciarmcom requested review from evedon, hugueskamba and a team March 9, 2021 18:00

ciarmcom added needs: review component: tools labels Mar 9, 2021

evedon approved these changes Mar 10, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Mar 10, 2021

hugueskamba approved these changes Mar 10, 2021

View reviewed changes

mergify bot added needs: work and removed needs: CI labels Mar 10, 2021

0xc0170 approved these changes Mar 11, 2021

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Mar 11, 2021

mergify bot added ready for merge and removed needs: CI labels Mar 11, 2021

0xc0170 merged commit 0ef2024 into ARMmbed:master Mar 11, 2021

mergify bot removed the ready for merge label Mar 11, 2021

LDong-Arm mentioned this pull request Mar 11, 2021

CMake: Fix Cortex-A9 flags for GCC_ARM toolchain #14411

Merged

This was referenced Mar 12, 2021

Bump mbed-os from f227856 to eec320c uwrobotics/MarsRoverFirmware#321

Closed

Bump mbed-os from f227856 to eec320c WolfgangWindholtz/MarsRover2020-firmware#43

Closed

mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workaround for Cortex-M33 Arm toochain linking #14401

Workaround for Cortex-M33 Arm toochain linking #14401

LDong-Arm commented Mar 9, 2021 •

edited

Loading

LDong-Arm Mar 9, 2021 •

edited

Loading

LDong-Arm Mar 9, 2021

ciarmcom commented Mar 9, 2021

evedon left a comment

hugueskamba left a comment •

edited

Loading

LDong-Arm commented Mar 10, 2021

adbridge commented Mar 10, 2021

LDong-Arm commented Mar 10, 2021

adbridge commented Mar 10, 2021

mbed-ci commented Mar 10, 2021

mbed-ci commented Mar 10, 2021

LDong-Arm commented Mar 11, 2021 •

edited

Loading

0xc0170 commented Mar 11, 2021

mbed-ci commented Mar 11, 2021

LDong-Arm commented Mar 11, 2021

	#Necessary as the linker does not always detect
	#the architecture from the objectfiles correctly.
	list(APPEND link_options
	"--cpu=Cortex-M4.no_fp"
	)

Workaround for Cortex-M33 Arm toochain linking #14401

Workaround for Cortex-M33 Arm toochain linking #14401

Conversation

LDong-Arm commented Mar 9, 2021 • edited Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

LDong-Arm Mar 9, 2021 • edited Loading

Choose a reason for hiding this comment

LDong-Arm Mar 9, 2021

Choose a reason for hiding this comment

ciarmcom commented Mar 9, 2021

evedon left a comment

Choose a reason for hiding this comment

hugueskamba left a comment • edited Loading

Choose a reason for hiding this comment

LDong-Arm commented Mar 10, 2021

adbridge commented Mar 10, 2021

LDong-Arm commented Mar 10, 2021

adbridge commented Mar 10, 2021

mbed-ci commented Mar 10, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

mbed-ci commented Mar 10, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

LDong-Arm commented Mar 11, 2021 • edited Loading

0xc0170 commented Mar 11, 2021

mbed-ci commented Mar 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

LDong-Arm commented Mar 11, 2021

LDong-Arm commented Mar 9, 2021 •

edited

Loading

LDong-Arm Mar 9, 2021 •

edited

Loading

hugueskamba left a comment •

edited

Loading

LDong-Arm commented Mar 11, 2021 •

edited

Loading